limit offered by facet to specific offerors #2692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAPI ChangesShow/hide 223 changes: 0 error, 0 warning, 223 info |
| aggregations: { | ||
| ...data.metadata.aggregations, | ||
| offered_by: data.metadata.aggregations.offered_by.filter( | ||
| (value) => value && value.key in offerors, |
Contributor
There was a problem hiding this comment.
Will leave review to @abeglova , but skimmed this and wanted to mention:
It's best to avoid in operator in JS, unfortunately. It dates from the dark(er) ages of JS (AI told me 1998) and has some odd behavior. For example, it checks membership in the object or object prototype, so
"hasOwnProperty" in {} // true
"map" in [] // true
"filter" in [] // true
"set" in new URLSearchParams() // true
Contributor
Author
There was a problem hiding this comment.
woops python brain kicked in. I switched it to Object.keys().includes
abeglova
reviewed
Nov 12, 2025
Contributor
Author
|
@abeglova the current failing test is a flaky one that Matt has fixed in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/9103
Description (What does it do?)
This PR makes it so we can configure what offerers show up as a facet on the search page. In our case we want to remove "bootcamps" and "mit climate" as options.
How can this be tested?
python manage.py update_index --allto sync the flag to opensearchAdditional context
This pr also includes a fix for a flaky test i noticed that is also affecting main